Statically ensure that `UserTopicVisibilityPolicy.unknown` is not possible in our data models
#1,074 创建于 2024年11月22日
仓库指标
- Star
- (454 star)
- PR 合并指标
- (PR 指标待抓取)
描述
This was brought up here: https://github.com/zulip/zulip-flutter/pull/1041#discussion_r1853230302.
UserTopicVisibilityPolicy.unknown allows us to deserialize unknown enum values gracefully at the edge.
However, while we manually declare that it wouldn't be possible that we encounter UserTopicVisibilityPolicy.unknown when accessing our internal data store (i.e.: ChannelStore), our type doesn't agree with that, and require the UserTopicVisibilityPolicy.unknown case to be handled for an exhaustive switch. We use assert in such cases, but it is not supposed to be reachable (unless we have a bug).
We should make sure that such an assertion is not needed. To do this, we'll:
- Remove
unknownfromUserTopicVisibilityPolicy. - In the places where it was needed, use a nullable type
UserTopicVisibilityPolicy?instead.
Out of scope
This may or may not apply to other unknown enum values. It would be good to do a sweep of those and decide if we need to follow-up on them as well.