zsh-users/zsh-syntax-highlighting

$READNULLCMD / $NULLCMD are red

Open

#716 创建于 2020年3月23日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Shell (22,617 star) (1,371 fork)batch import
BugTaskgood first issuesyntax:command-word

描述

% tests/generate.zsh '$NULLCMD | $READNULLCMD' main nullcmd 'local NULLCMD=cat READNULLCMD=f; f(){};' 
Set copyright year to 2020? y
local NULLCMD=cat READNULLCMD=f; f(){};

BUFFER=$'$NULLCMD | $READNULLCMD'

expected_region_highlight=(
  '1 8 unknown-token' # $NULLCMD
  '10 10 commandseparator' # |
  '12 23 unknown-token' # $READNULLCMD
)

That's likely because they're special, and as such don't get expanded (which makes this another case of #695):

% p ${(t)READNULLCMD} ${(t)NULLCMD}
scalar-special scalar-special

贡献者指南

技术栈
shell
领域
developer experiencecli
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
basic zsh knowledgegitshell scripting
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate how $NULLCMD and $READNULLCMD are handled in the highlighting code (likely in 'highlighters/main/main highlight.zsh'). The issue notes they have the 'special' attribute, which prevents expansion. See reference to issue #695 for similar cases. The fix likely involves adding them to a list of variables that should be expanded despite being special. Look for where other special variables are expanded and replicate for these two.