zsh-users/zsh-syntax-highlighting

"unknown-token" is overloaded

Open

#695 创建于 2020年3月15日

在 GitHub 查看
 (3 评论) (1 反应) (0 负责人)Shell (22,617 star) (1,371 fork)batch import
FeatureIdeaImprovementTaskcomponent:testsgood first issue

描述

Highlighting all errors the same way makes sense from a UI perspective (cough #691 cough), but it makes the tests weaker: when a test checks that an alias is highlighted as unknown-token, it can't easily check whether that's due to a syntax error (as in alias x='() ]]') or due to, say, a command word not being an existing alias/function/etc. (as fixed in 9931990b92a276c6ec69cdf6af9f9f3b65603cd1).

How about adding some new styles for more specific errors — e.g., unknown-token-not-a-command-name, unknown-token-parse-error, etc — that will be highlighted the same way by default, but will make the tests more specific?

贡献者指南

技术栈
shell
领域
testingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic understanding of zsh syntax highlighting plugin
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Look at the existing style definitions in the plugin's source code, likely in files like 'highlighters/main/main highlighter.zsh' or similar. Examine how 'unknown token' is currently defined and used in tests, for example in the test files under 'highlighters/main/test data/'. The goal is to add new style names like 'unknown token not a command name' and 'unknown token parse error' that map to the same visual style as 'unknown token' but allow tests to specify the exact error type. Review the linked issue #691 and commit 9931990b92a for context on the current behavior and test weaknesses.