zsh-users/zsh-syntax-highlighting

PATH_DIRS shouldn't be honoured after `sudo`

Open

#595 创建于 2018年12月24日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)Shell (22,617 star) (1,371 fork)batch import
Buggood first issuesyntax:command-word

描述

The main highlighter explicitly sets PATH_DIRS if the user has that enabled:

https://github.com/zsh-users/zsh-syntax-highlighting/blob/55f846c673661bde03ef97333be7889f54079c7b/highlighters/main/main-highlighter.zsh#L316-L318

This is so, if $^path/foo/bar(*N) exists, % foo/bar will be highlighted in green. However, that also happens in sudo foo/bar, even though sudo doesn't do path searches when there's a / in the argument — at least, I think that's how sudo behaves, but double-check that before making any code change on our end.

贡献者指南

技术栈
shell
领域
clideveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
zsh shellsudo behaviorzsh syntax highlighting codebase
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate sudo behavior: confirm whether sudo performs path searches when the argument contains a slash (likely not). Then modify main highlighter.zsh around line 316-318 to skip setting PATH DIRS for commands like sudo. The fix is localized and should be straightforward.
PATH_DIRS shouldn't be honoured after `sudo` · zsh-users/zsh-syntax-highlighting#595 | Good First Issue