zephyrproject-rtos/zephyr

Bluetooth: Audio: Add checks for bt_conn_ref return value where applicable

Open

#95,148 创建于 2025年8月29日

在 GitHub 查看
 (1 评论) (0 反应) (2 负责人)C (15,249 star) (9,144 fork)batch import
EnhancementGood first issuearea: Bluetootharea: Bluetooth Audio

描述

Summary

If the connection pointer supplied to an API call is not connected (e.g. if the application has cached it incorrectly), then when we perform a bt_conn_ref in the LE Audio code to take a reference, it can return NULL, which indicates a non-connected bt_conn pointer.

Describe the solution you'd like

For each call of bt_conn_ref in LE Audio from a struct bt_conn * from the higher layers, we need to verify that the return value is non-NULL.

Alternatives

Alternatively, we should check early in the function if the struct bt_conn is in the connected state. If a user attempts to perform any operation that expects the connection to be connected, and it is not, then we should return early to avoid unncessary memory copies etc. to generate the PDUs.

No response

Additional Context

This may also be an issue in other non-LE Audio places.

贡献者指南

技术栈
c
领域
security
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C programmingPointer managementBluetooth LE Audio concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Locate all calls to bt conn ref in the LE Audio subsystem (likely under subsys/bluetooth/audio/). For each call, verify if the return value is checked for NULL and add a null check with an early return or appropriate error handling. Consider also adding a state check on the bt conn pointer to confirm it is connected, as suggested in the issue. Look at existing implementations in other Bluetooth profiles (e.g., HFP, A2DP) for patterns of reference counting and error handling. Since this issue has assignees, it is recommended to coordinate or check if any work is already in progress.