Drop Futile BUILD_ASSERTs in tmc5xxx series · zephyrproject-rtos/zephyr

(2 条评论) (1 个反应) (1 位负责人)C (9,144 个派生)batch import

Good first issuearea: Stepper

仓库指标

星标: (15,249 个星标)
PR 合并指标: (PR 指标待抓取)

描述

Summary

stallguard_threshold_velocity is actually part of adi,tmc5xxx-stepper-ctrl bindings. https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/dts/bindings/stepper/adi/adi%2Ctmc50xx-stepper-ctrl.yaml#L10 https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/drivers/stepper/adi_tmc/tmc51xx/tmc51xx_stepper_ctrl.c#L493

However, couple of other drivers in the tmc5xxx series do BUILD_ASSERT on this property. The ASSERT never actually happens since it's guarded by a COND_CODE_1, which would never be tree, hence it's actually futile.

https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/drivers/stepper/adi_tmc/tmc51xx/tmc51xx.c#L528-L530

Describe the solution you'd like

Drop the ASSERTs listed below.

Alternatives

No response

Additional Context

No response

贡献者指南

研究方向: The issue involves removing three futile BUILD ASSERT macros from files: drivers/stepper/adi tmc/tmc51xx/tmc51xx.c (lines 528-530), drivers/stepper/adi tmc/tmc51xx/tmc51xx stepper driver.c (lines 205-207), and drivers/stepper/adi tmc/tmc50xx/tmc50xx stepper driver.c (lines 170-172). The asserts are guarded by COND CODE 1 on a property that never exists, so they are dead code. The fix is to delete those lines. The issue is assigned but has no open PR, so check assignee status before starting.
技术栈: c
领域: backend
议题类型: 重构
难度: 2
预计时间: 1 小时以内
活动状态: 已阻塞
清晰度: 清晰
前置要求: C programming
新手友好度: 40