zenoamaro/react-quill

False positive "You are passing the delta object from the onChange event back as value"

Open

#498 创建于 2019年7月8日

在 GitHub 查看
 (6 评论) (7 反应) (0 负责人)JavaScript (6,238 star) (860 fork)batch import
good first issuehelp wanted

描述

In my case, when both nextContents and this.lastDeltaChangeSet are undefined, I get this error. It happens in a real scenario when I switch between 2 records, and component.js componentWillReceiveProps gets called

From component.js:

if (nextContents === this.lastDeltaChangeSet) {
        console.error(nextContents, this.lastDeltaChangeSet)
        throw new Error(
          'You are passing the `delta` object from the `onChange` event back ' +
            'as `value`. You most probably want `editor.getContents()` instead. ' +
            'See: https://github.com/zenoamaro/react-quill#using-deltas'
        )
      }

React-Quill version

1.3.3

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
React component lifecycleQuill delta understanding
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
The issue is in component.js, where a check throws an error when both nextContents and this.lastDeltaChangeSet are undefined. The condition should handle the case where both are undefined (e.g., first render with no value). Look at the React component's componentWillReceiveProps method and the delta comparison logic. Consider adding a guard clause returning early when both are undefined to avoid the false positive.