zalmoxisus/redux-devtools-extension

Sets aren't properly diffed or displayed

Open

#452 创建于 2018年1月30日

在 GitHub 查看
 (1 评论) (8 反应) (0 负责人)JavaScript (13,478 star) (1,074 fork)batch import
help wantedmonitor

描述

Just wanted to make you aware of a possible bug. When passing a new set as a key of the initial state:

{
  items: new Set()
}

and then later adding to the set like so:

const newItems = new Set(state.items)
newItems.add("newItem")
return {...state, items: newItems}

the redux devtools evaluates the diff as no change, while logging the state shows that an item was added.

Let me know if you want any more details about this bug. I have a workaround that I'm using to log the items when needed, but thought you might want to know.

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Understanding of Redux DevTools extensionFamiliarity with JavaScript Set and object diffing
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate how the Redux DevTools extension computes state diffs. The issue likely lies in the diffing logic that may not handle non plain objects like Set. Look for files related to state comparison or diffing, such as 'src/browser/extension/inject/diff.js' or similar. Check if the extension uses JSON.stringify or a custom deep equal function that fails on Set. Consider implementing a custom diff that handles Set by converting to array or using iterator.