yugabyte/yugabyte-db

ysql: fix uses of parser_ybc_beta_feature

Open

#10,263 创建于 2021年10月12日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)C (1,003 fork)batch import
area/ysqlgood first issuehelp wantedkind/enhancementpriority/medium

仓库指标

Star
 (8,229 star)
PR 合并指标
 (平均合并 17天 21小时) (30 天内合并 92 个 PR)

描述

Jira Link: DB-1261 There are multiple issues with the individual beta feature flags. I believe the core issue is lack of understanding of parser_ybc_beta_feature. See the definition:

#define parser_ybc_beta_feature(pos, feature, has_own_flag) \
    check_beta_feature(pos, yyscanner, has_own_flag ? "FLAGS_ysql_beta_feature_" feature : NULL, feature)

If has_own_flag is true, there should be a corresponding flag declared, and feature should not have whitespace. It looks like this macro was used properly until commit a3c112233b621164d4367420c9db619aae7cf1c5. Bad uses include commit bc28a34342f94a0ee89391a98ccd1c174d5d0ba7 (my fault, cc: @robertsami) and 830ba9964031fbcbff9e1fb07cf8a215cfd7c7fa (PR #9650, cc: @fizaaluthra).

贡献者指南