you-dont-need/You-Dont-Need-JavaScript

Click on button for modal scrolls page to top

Open

#10 创建于 2016年7月5日

在 GitHub 查看
 (10 评论) (0 反应) (1 负责人)HTML (20,530 star) (1,496 fork)batch import
PR Welcomehelp wanted

描述

In the modal example, when you click on the button to show the modal, the modal shows but the page also scrolls to the top. This would end up as a bug in our backlog :)

贡献者指南

技术栈
htmlcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic HTML and CSS
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The issue is that clicking a button to open a modal also causes the page to scroll to the top. This is likely due to the default behavior of anchor links or button events. To fix, investigate the modal trigger implementation, perhaps using event.preventDefault() or changing the href attribute. Look at the modal component code in the repository, possibly in the examples folder. The existing comments may provide more context.