yarnpkg/yarn

'yarn pack' should not process .gitignore if .npmignore is present

Open

#754 创建于 2016年10月11日

在 GitHub 查看
 (9 评论) (5 反应) (0 负责人)JavaScript (41,514 star) (2,731 fork)batch import
cat-bughelp wantedtriaged

描述

Do you want to request a feature or report a bug?

Report a bug.

What is the current behavior?

yarn pack ignores files specified in .gitignore while npm pack does not.

When .js files are generated from another language or flavor of javascript, generated files are often not checked-in and thus *.js or **/*.js entry is added to .gitignore. These generated files should be included in the package at runtime.

If the current behavior is a bug, please provide the steps to reproduce.

  1. create index.js file at project root.
  2. create .gitignore file at project root with entry *.js.
  3. run yarn pack.
  4. decompress package .tgz file.
  5. index.js file will not be in the decompressed package, only package.json and node_modules.

What is the expected behavior?

index.js should be there.

Please mention your node.js, yarn and operating system version.

Node.js v6.7 Yarn v0.15.1 macOS Sierra

贡献者指南

技术栈
nodejsjavascript
领域
backendtooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Understanding of npm packFamiliarity with .npmignore and .gitignore
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the `yarn pack` command implementation, likely in `src/commands/pack.js`. The issue expects that if a `.npmignore` file exists, `.gitignore` should be ignored entirely, following npm's behavior. Review the current logic for file exclusion and compare with npm's source code. Check if there are any comments or linked PRs (none visible). The maintainers may have indicated desired behavior; look through issue comments #754 for any guidance.