yarnpkg/yarn

Yarn ignores no_proxy environment variable when proxy property set

Open

#5,048 创建于 2017年12月6日

在 GitHub 查看
 (33 评论) (24 反应) (1 负责人)JavaScript (41,514 star) (2,731 fork)batch import
cat-compatibilitycat-featurehelp wantedtriaged

描述

Do you want to request a feature or report a bug? Both

What is the current behavior? If proxy and http-proxy are set, NO_PROXY and no_proxy environment variables are ignored.

If the current behavior is a bug, please provide the steps to reproduce.

  1. Set proxy and https-proxy config and can find from yarn config list
...
info npm config
{ proxy: 'http://some.proxy.host:8080/',
  'https-proxy': 'http://some.proxy.host:8080/',
...
  1. Set NO_PROXY or no_proxy environment variable like $ no_proxy="some.url.private.repo"
  2. Run yarn install
  3. proxy and https-proxy work but no_proxy environment variable is ignored.

What is the expected behavior? NO_PROXY or no_proxy environment variable is applied.

Please mention your node.js, yarn and operating system version. Ubuntu 16.04 yarn 1.3.2

贡献者指南

技术栈
javascriptnodejs
领域
backendcli
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
familiarity with Node.js networkingunderstanding of environment variables
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate how Yarn currently applies proxy settings from config and environment variables. Look at the code that reads 'proxy' and 'https proxy' config values and the logic that checks 'no proxy' / 'NO PROXY' environment variable. The issue indicates that when proxy is set via config, the no proxy env variable is ignored. Identify the specific file and function where proxy resolution occurs (likely in src/util/network.js or similar). Check if there is an existing utility to parse no proxy. Consider adding a check for no proxy before applying the proxy agent.