yarnpkg/yarn

Inconsistent config strings

Open

#4,496 创建于 2017年9月18日

在 GitHub 查看
 (9 评论) (0 反应) (0 负责人)JavaScript (41,514 star) (2,731 fork)batch import
cat-featuregood first issuehelp wantedtriaged

描述

Continuation from #4457

Do you want to request a feature or report a bug? Potential bug.

What is the current behavior? Yarn config has different formatting for object keys that are computed / set vs defaults.

I'm not sure I understand if this is by design or not. If so, what is the use case?

Initial registry configuration

What is the expected behavior? Keys should all be wrapped in single quotes or DEFAULTS should follow same formatting as registry, lastUpdateCheck, and user configured values do

Please mention your node.js, yarn and operating system version. Yarn: 1.0.2 Node: 8.1.4

Happy to submit a PR if the current functionality isn't as expected.

贡献者指南

技术栈
javascript
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Fix the inconsistency in formatting of config keys in src/registries/yarn registry.js, where default keys are not wrapped in single quotes while others are. Ensure all keys use the same quoting style. See issue #4457 for prior discussion.