Bad file paths when publishing on Windows (backslash in package file paths) · yarnpkg/yarn#3031

(1 评论) (2 反应) (0 负责人)JavaScript (41,514 star) (2,731 fork)batch import

cat-buggood first issueneeds-confirmationos-windowstriaged

描述

Do you want to request a feature or report a bug? bug

What is the current behavior? Packages published via yarn publish, on Windows, seem to use backslash as a path separator for file paths. This becomes a problem when these packages are added on *nix systems where the backslash is interpreted as part of the filename and not as a directory separator.

So if a package is published, on Windows, with the following file path: dist/test.min.js When added, on a *nix system, the file is downloaded and created as: dist\test.min.js

If the current behavior is a bug, please provide the steps to reproduce.

Publish a package on a Windows system (yarn publish blah)
Add that package as dependency to a project via yarn add blah on a *nix system

What is the expected behavior? Directory structure of published folder from a Windows system will be retained when adding package on *nix system.

Please mention your node.js, yarn and operating system version. System used to publish:

node v6.9.1
yarn v0.21.3
Windows 10 Home v1607 (64-bit)

System used to add:

node v7.8.0
yarn v0.21.3
Ubuntu 14.04

贡献者指南

技术栈: nodejs
领域: release
议题类型: bug
难度: 3
预计时间: half day
活动状态: stale
清晰度: clear
前置要求: Node.js basicsCross platform path handling
新手友好度: 65
研究方向: The issue is about backslashes in file paths when publishing a package on Windows. To fix, locate the code that generates the file paths for the package tarball (likely in the packer module). Ensure that all paths are normalized to use forward slashes before writing to the tarball. Also check if the installation code correctly handles forward slashes on Windows. Consult the existing tests for cross platform path handling and consider adding a new test for this scenario.