yarnpkg/yarn

Yarn does not remove old package name from yarn.lock when install from git repo

Open

#2,840 创建于 2017年3月6日

在 GitHub 查看
 (6 评论) (5 反应) (0 负责人)JavaScript (41,514 star) (2,731 fork)batch import
cat-buggood first issuehelp wantedtriaged

描述

yarn version 0.21.3

Do you want to request a feature or report a bug? bug

What is the current behavior? When install new package which is the same name as the old one from git repo, the old package in yarn.lock does not disappear.

the steps to reproduce :

npm init -y
yarn add https://github.com/FF-Mercurial/ug
yarn add https://github.com/kokororin/ug

see yarn.lock:

"ug@https://github.com/FF-Mercurial/ug":
  version "1.0.0"
  resolved "https://github.com/FF-Mercurial/ug#5a0400908d4a2b3ad8ce6d9a4c42fd3d3640983c"
  dependencies:
    escodegen "^1.6.1"
    esprima "^2.5.0"
    uglify-js "^2.4.24"

"ug@https://github.com/kokororin/ug":
  version "1.0.0"
  resolved "https://github.com/kokororin/ug#d38db29b6ce10037d235875c3b5b56b97a36877e"
  dependencies:
    escodegen "^1.6.1"
    esprima "^2.5.0"
    uglify-js "^2.4.24"

What is the expected behavior? The old package in yarn.lock should be removed.

Please mention your node.js, yarn and operating system version.

$ ver
Microsoft Windows [版本 6.1.7601]

$ node -v && yarn --version
v7.5.0
0.21.3

贡献者指南

技术栈
javascriptnodejs
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic understanding of yarn and yarn.lockFamiliarity with git dependencies
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the yarn.lock resolution logic when adding a package from a git URL. The bug occurs because yarn does not remove the old entry when a package with the same name is replaced. Look at the lockfile module, likely in `src/lockfile/` or similar. Check the comments on the issue for any maintainer suggestions.