yarn publish changes version with wrong password · yarnpkg/yarn#1675

(2 评论) (0 反应) (0 负责人)JavaScript (41,514 star) (2,731 fork)batch import

cat-buggood first issuehelp wantedtriaged

描述

Do you want to request a feature or report a bug? Bug

What is the current behavior? Yarn will refuse to publish a package if the version doesn't change:

error New version is the same as the current version.

It also bumps the version before logging in, so if auth fails, you'll be in an error state.

If the current behavior is a bug, please provide the steps to reproduce.

yarn publish
// enter new version
// enter wrong npm password
error Incorrect username or password.
yarn publish
error New version is the same as the current version.

What is the expected behavior? yarn publish should only error if the version currently posted on npmjs.org is the same as the version in package.json

Please mention your node.js, yarn and operating system version. yarn publish v0.15.1 node v6.2.1 macOS 10.11.6

贡献者指南

技术栈: javascriptnodejs
领域: clirelease
议题类型: bug
难度: 3
预计时间: half day
活动状态: stale
清晰度: clear
前置要求: JavaScriptNode.jsnpm publishingYarn internals
新手友好度: 50
研究方向: Investigate the publish command's flow in the source code, likely in `src/cli/commands/publish.js` or similar. The version bump should occur only after successful authentication with the npm registry. Check the order of operations and ensure that the version is not updated if authentication fails. Look at the error handling and consider adding a check before modifying package.json.