yairEO/tagify

appendTarget hiding/selecting issues for shadowdom

开放

#1,390 创建于 2024年10月17日

 (4 条评论) (0 个反应) (0 位负责人)HTML (456 个派生)github user discovery
Help wantedSuggestion

仓库指标

星标
 (3,880 个星标)
PR 合并指标
 (30 天内没有已合并 PR)

描述

Prerequisites

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

💥 Demo Page

I can do it in some days, i need some time to build a simple lit element for this.

Explanation

  • What is the expected behavior?

There are a lot of document.body checks in the code which doesn't work in shadowdom. It should be the appendTarget element:

https://github.com/yairEO/tagify/blob/master/src/parts/dropdown.js#L155 https://github.com/yairEO/tagify/blob/master/src/parts/dropdown.js#L218

  • What is happening instead?

Checking in the document.body instead of appendTarget

  • What error message are you getting?

A lot of glitches.

贡献者指南