xtermjs/xterm.js

Search is not incremental

Open

#5,177 创建于 2024年10月3日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)TypeScript (16,196 star) (1,574 fork)batch import
area/addon/searcharea/performancehelp wantedtype/bug

描述

See https://github.com/xtermjs/xterm.js/issues/5176 for context

All searches take the same amount of time when the latter ones should take much less time due to being incremental:

Test file:

test.txt

Image

贡献者指南

技术栈
typescript
领域
frontendperformance
议题类型
performance
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
understanding of search algorithmsfamiliarity with xterm.js addons
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Refer to the linked issue #5176 for context. The search is implemented in the search addon of xterm.js. Investigate the existing search implementation (likely in src/addons/search/) to understand why each search iteration is not incremental. Look for opportunities to memoize or cache results from previous searches to reduce time for subsequent searches.
Search is not incremental · xtermjs/xterm.js#5177 | Good First Issue