xtermjs/xterm.js

Search is too slow

已关闭

#5,176 创建于 2024年10月3日

在 GitHub 查看贡献者指南
 (34 条评论) (4 个反应) (0 位负责人)TypeScript (1,574 个派生)batch import
area/addon/searcharea/performancehelp wantedtype/bug

仓库指标

星标
 (16,196 个星标)
PR 合并指标
 (平均合并 2天 10小时) (30 天内合并 16 个 PR)

描述

Currently the search addon limits itself to 1000 highlights by default. Contrast this to monaco's 20000 results before it gives up highlighting. When we increase our limit to 20000 the search itself ends up blocking the renderer pretty significantly.

Here is a profile using my i7-12700KF 3.61 GHz:

test file test.txt

Image

Image

Note that the search is also not incremental, so all successive searches take the same amount of time even for non-regex searches. https://github.com/xtermjs/xterm.js/issues/5177

VS Code issue: https://github.com/microsoft/vscode/issues/230365

贡献者指南

研究方向
Investigate the search addon in xterm.js (likely in addons/search/). The issue shows that increasing the highlight limit causes renderer blocking; profile the search function to identify bottlenecks. Consider implementing incremental search to avoid re searching non regex queries (see linked issue #5177). Evaluate using a web worker to offload search computation. The test file provided can be used to reproduce the slowdown.
技术栈
typescript
领域
frontendperformance
议题类型
性能
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
半天
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
活跃
清晰度议题是否清楚说明期望改动、验收标准和下一步。
基本清晰
前置要求
Familiarity with xterm.js search addonBasic profiling skills
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60