xtermjs/xterm.js

The terminal instance cannot be rendered correctly after calling `.open()` for the second time.

Open

#4,978 创建于 2024年3月3日

在 GitHub 查看
 (10 评论) (0 反应) (1 负责人)TypeScript (16,196 star) (1,574 fork)batch import
help wantedtype/bug

描述

I am new to using xtermjs. I am not sure whether the terminal instance can call the open() method multiple times. According to the official documentation and https://github.com/xtermjs/xterm.js/issues/1323, I tried it. When I removed the dom and mounted again, and used terminal.open(), xterm did not render after the second open.

Details

  • Browser and browser version: chrome 122.0.6261.94
  • OS version: macOS 14.3
  • xterm.js version: 5.4.0

Steps to reproduce

Reproduce

  1. Click the toggle button, xterm renders correctly.
  2. Click the toggle button, remove dom
  3. Click the toggle button, mount dom, xterm did not render after the second open

I'm sorry if there's something wrong with my usage

贡献者指南

技术栈
typescriptjavascripthtmlcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
needs maintainer response
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Familiarity with xterm.js APIUnderstanding of DOM lifecycle
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the behavior of Terminal.open() when called multiple times. The issue provides a reproduction in CodeSandbox (App.tsx) and references previous issue #1323. Check the source code for cleanup logic in the open method, and whether the terminal properly detaches from the old DOM element. Look for any state that might not be reset on subsequent calls. Consider adding a check or update to the documentation to clarify expected usage.