xtermjs/xterm.js

Infinite loop when drawing large ligatures to char atlas

开放

#4,362 创建于 2023年1月2日

 (1 条评论) (0 个反应) (0 位负责人)TypeScript (1,574 个派生)batch import
area/addon/ligaturesarea/addon/webglhelp wantedtype/bug

仓库指标

星标
 (16,196 个星标)
PR 合并指标
 (平均合并 2天 10小时) (30 天内合并 16 个 PR)

描述

some fonts provide extremely long ligatures, e.g. Fira Code for =================================================== The char atlas code tries to find a row to fit it but fails and gets stuck in an infinite loop https://github.com/xtermjs/xterm.js/blob/fe8981766769c19ab1903dffa19f1a64ad83da13/src/browser/renderer/shared/TextureAtlas.ts#L792-L799 ^Here we're checking if there's room on the current row and creating a new one if not.

Details

  • Browser and browser version: chrome 108
  • OS version: macOS 12
  • xterm.js version: 5.1.0 (also on latest master branch)

Steps to reproduce

  1. Install Fira Code font, Run the xterm demo and enable ligatures
  2. start typing =
  3. Keep looking at the char atlas drawn below, once the glyph is almost the same width as char atlas, typing the next = will freeze everything.

贡献者指南