Issue in Linkifier2._removeIntersectingLinks · xtermjs/xterm.js#4296

(0 评论) (0 反应) (0 负责人)TypeScript (16,196 star) (1,574 fork)batch import

area/linkshelp wantedtype/bug

描述

Coming from https://github.com/xtermjs/xterm.js/pull/4288.

There is an issue with the private method Linkifier2._removeIntersectingLinks not correctly respecting multiple wrapped links in one merged line, which leads to wrong removal of later links.

On a first look it seems the method does not account y-progression, thus later links are mistaken as overlapping from their column position only.

贡献者指南

技术栈: typescript
领域: frontend
议题类型: bug
难度: 3
预计时间: 1-3 hours
活动状态: fresh
清晰度: mostly clear
前置要求: understanding of xterm.js linkifier architecture
新手友好度: 30
研究方向: Examine the private method ` removeIntersectingLinks` in `Linkifier2.ts`. The issue indicates it fails to account for y progression when multiple wrapped links exist in a merged line. Check the linked PR #4288 for additional context and potential partial fix. The fix likely involves adjusting the intersection logic to compare both row and column positions rather than just column.