xtermjs/xterm.js

Auto fit addon doesn't work when parent element uses border-box

Open

#1,283 创建于 2018年2月12日

在 GitHub 查看
 (4 评论) (0 反应) (1 负责人)TypeScript (16,196 star) (1,574 fork)batch import
area/addon/fitgood first issuehelp wantedtype/bug

描述

The calculations for height and width of the parent in the auto fit plugin are incorrect when the parent element uses box-sizing: border-box. This is because the computed height includes the padding but the content does not.

The right implementation might be to get the client height of the parent element using gBCR and then subtract the parent padding.

/CC @taion

贡献者指南

技术栈
typescriptcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
CSS box sizingJavaScriptxterm.js addon conventions
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue is in the fit addon's fit.ts file (lines 30-31) where the computed height and width are incorrect when the parent uses border box. The fix involves using getBoundingClientRect (gBCR) to get the client height and width, then subtracting the parent padding. Implement this change in the fit function. Ensure tests pass and verify with a parent that has box sizing: border box.