xgfe/react-native-datepicker

Please put example code in sub directory

Open

#81 创建于 2017年2月9日

在 GitHub 查看
 (2 评论) (2 反应) (0 负责人)JavaScript (2,109 star) (737 fork)batch import
enhancementhelp wanted

描述

Hi, thanks for the great work. When I initially saw your codebase, I thought this was a React Native bridge module, but then came to understand it was a JS-only package. This is because I saw the android and ios directories. Also I was confused at index.ios.js and index.android.js files.

Typically in a RN library you put example code in a sub directory called Example or whatever. This will eliminate any confusion. If you need help, let me know and I'll create a PR for it

贡献者指南

技术栈
react nativejavascriptandroidios
领域
mobile
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with React Native project structureBasic knowledge of file organization
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
First, examine the repository's root directory structure to locate existing example files (e.g., index.ios.js, index.android.js) and the android/ and ios/ directories. Then create an 'Example' subdirectory and move those files into it. Update any import paths within the moved files to reflect the new location. Also check the README or other documentation for references to the example code and update those paths accordingly. Ensure the example still works after the move.