xamarin/Xamarin.Forms

Android: Master Navigation page displayed as third bottom tabbar item

Open

#9,143 创建于 2020年1月9日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)C# (5,644 star) (1,926 fork)batch import
4.3.0help wantedi/regressionin-progressinactivep/Androidt/bug :bug:up-for-grabs

描述

Description

We have the following pages structure: MainPage = MasterDetailPage:

  • Master: a Navigation page with a single Content page
  • Detail: a Tabbed page with 5 tabs: --- each tab is a Navigation page with a single Content page in it

Toolbar placement is set to Bottom for Android.

Steps to Reproduce

Run the attached test project on android device.

Expected Behavior

Third bottom tabbar item is displayed similar to other tabbar items. Master page is accessible via the hamburger icon.

Actual Behavior

Master page is displayed instead of third bottom tabbar item. Master page is not displayed when tapping on the hamburger icon.

Basic Information

  • Version with issue: 4.3.0.908675
  • Last known good version: 4.2.0.910310
  • IDE: Visual Studio 2019 (16.4.0) for Windows
  • Platform Target Frameworks:
    • Android: 9.0
  • Nuget Packages: NETStandard.Library (2.0.3), Xamarin.Essentials (1.3.1)
  • Affected Devices: HUAWEI VTR-L09 and others (we experienced this on multiple of our test devices)

Screenshots

Screenshot_20200120-173631 Screenshot_20200120-173639

Reproduction Link

AppWithMenuInsteadOfTabbedItem.zip

Notes

Looks like the issue was introduced with this pull request: https://github.com/xamarin/Xamarin.Forms/pull/6471 (we reverted this file and the bottom tabbar behaved correctly). Using random numbers as Ids for MasterDetailContainer also solves the issue (looks like Master navigation page gets the same ID assigned as third bottom tabbar item?).

贡献者指南

技术栈
csharpandroid
领域
mobile
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic knowledge of Xamarin.FormsAndroid development environment
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
Start by examining the reproduction project attached to the issue (AppWithMenuInsteadOfTabbedItem.zip). The issue notes that reverting file changes from PR #6471 fixes the problem, suggesting a regression. Focus on the MasterDetailContainer ID assignment logic in that PR, as random IDs solve the issue. Check the Android specific renderer code for MasterDetailPage and TabbedPage to understand how IDs are generated and assign the master navigation page incorrectly to the third tab.