xamarin/Xamarin.Forms

MasterDetailPage layout issues on iPhone X in landscape orientation

Open

#1,491 创建于 2018年1月2日

在 GitHub 查看
 (6 评论) (1 反应) (0 负责人)C# (5,644 star) (1,926 fork)batch import
e/2 :clock2:good first issuehacktoberfest 🍻help wantedp/iOS 🍎t/bug :bug:up-for-grabs

描述

Description

On iPhone X in landscape orientation, the Master part of the Xamarin.Forms.MasterDetailPage is mislocated and partially cut off from display (as observed on iPhone X iOS 11.2 simulator).

Steps to Reproduce

  1. Open attached sample project
  2. Run project in iPhone X iOS 11.2 simulator --> app will initially show "Contacts Page" with menu icon in upper left corner
  3. Change device orientation to landscape
  4. Tap on menu icon to present Master part

Expected Behavior

  • Master part should be located on the left-hand side of the screen (with some left margin to respect safe area guides)
  • Master part should be fully visible and Detail part moved to the right accordingly (i.e. lorem ipsum text should be fully readable)

Actual Behavior

  • Master part has a left margin which is too large (i.e. more than required by safe area guides)
  • rather than being fully visible, Master part is cut off from display at the right edge (i.e. lorem ipsum text not fully readable)

Basic Information

  • Version with issue: Xamarin.Forms 2.5.0.122203
  • Last known good version: ?
  • IDE: see attached text file with IDE information

IDE_info.txt

Screenshots

First screenshot: portrait orientation, correct display

screen01_portrait_correctdisplay

Second screenshot: landscape orientation, incorrect display

screen02_landscape_incorrectdisplay

Reproduction Project

MasterDetailPage.zip

贡献者指南

技术栈
csharpios
领域
mobile
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Xamarin.Forms layoutiOS safe area guides
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue is a layout bug on iPhone X in landscape for MasterDetailPage. The fix likely involves adjusting the Master part's frame to respect safe area insets. Look at the iOS renderer in Xamarin.Forms.iOS, specifically the MasterDetailPageRenderer. The reproduction project is attached. Check the comments on the issue for any guidance. The expected behavior is that the Master part should have a left margin from safe area and be fully visible. Investigate how the safe area insets are applied to the master view.