winstonjs/winston

Custom log levels can be silent unless level is also specified

Open

#1,491 创建于 2018年10月3日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)JavaScript (21,967 star) (1,789 fork)batch import
BugGood First IssueHelp Wanted

描述

It is easy to write the following code and not realize that one has made a mistake:

const logger = winston.createLogger({
  levels: { eeny: 0, meeny: 1, miney: 2, moe: 3},
  transports: [
    new winston.transports.Console(),
  ]
});

logger.meeny('catch a tiger by the toe'); // never hollers

This could be addressed by the following check in the Logger constructor:

    if (!Object.keys(this.levels).includes(this.level)) {
      throw new Error(`Logger level ${this.level} is not in the levels: ${this.levels}`);
    }

I can open a PR if people agree it is worth fixing.

贡献者指南

技术栈
javascript
领域
backenddeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
Investigate the current implementation of the Logger constructor in the winston source code (likely in lib/winston/logger.js). Review the comments on this issue for any maintainer feedback or alternative approaches. Implement the validation check as suggested in the issue body, ensuring it throws an error if the specified level is not in the custom levels object.
Custom log levels can be silent unless level is also specified · winstonjs/winston#1491 | Good First Issue