whatwg/html

Small clarity improvements to canvas transform methods

开放

#2,848 创建于 2017年7月19日

 (7 条评论) (1 个反应) (0 位负责人)HTML (2,520 个派生)batch import
clarificationgood first issuetopic: canvas

仓库指标

星标
 (7,654 个星标)
PR 合并指标
 (平均合并 42天 18小时) (30 天内合并 22 个 PR)

描述

While in the area for #2845, I noticed the following small tweaks that we could make to improve that section of the spec:

  • Replace "abort these steps" with "return" everywhere. (The latter is a more modern convention, per Infra.)
  • Link "multiplying" in the definition of transform(a, b, c, d, e, f) to https://drafts.fxtf.org/geometry/#matrix-multiply
  • Re-do setTransform(a, b, c, d, e, f) steps 2-3 to reset the current transformation matrix to the appropriate matrix (a c e / b d f / 0 0 1), instead of resetting the matrix to the identity matrix then invoking the transform() method. It's bad practice to invoke methods from other methods.

This is a good first bug :)

贡献者指南