welldone-software/why-did-you-render

Wdyr ignores equality function in useSelector

Open

#190 创建于 2021年4月16日

在 GitHub 查看
 (3 评论) (1 反应) (0 负责人)JavaScript (10,560 star) (188 fork)batch import
Low prioritybuggood first issuehelp wanted

描述

When using wdyr I noticed that it reports unnecessary renders caused by useSelector with an equality function even though the equality function causes the render to be avoided. Looking at the code it looks like wdyr does not consider the result of the equality function.

An example:

useSelector(someSelector, (prev, next) => true);

贡献者指南

技术栈
javascriptreact
领域
frontenddeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React basicsunderstanding of useSelectorfamiliarity with wdyr
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Start by locating the code in the why did you render repository that tracks renders and detects unnecessary re renders. Specifically, look for how useSelector is patched and where the equality function is called. The issue suggests that the equality function's result is ignored. Investigate the patch logic in files like 'trackHooks.js' or similar. Check the existing comments and any linked PRs for additional context. Confirm that the equality function result is not considered and then implement a fix that respects it.