webtorrent/webtorrent

`maxConns` option is ignored for incoming connections

Open

#703 创建于 2016年3月29日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)JavaScript (30,002 star) (2,748 fork)batch import
area/perfbughelp wanted

描述

The maxConns option is currently ignored for incoming connections, so there's effectively no limit the number of incoming connections that we accept.

For TCP, we could just immediately destroy the incoming connection, or perhaps pause the server somehow to avoid accepting in the first place? For WebRTC, we should consider not ever returning an offer when we're at capacity, since doing the whole signaling process is expensive (webrtc conns are a limited resource; and trackers have limited resources)

贡献者指南

技术栈
javascript
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Understanding of TCP server architecturesBasic knowledge of WebRTC signaling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
The issue describes that maxConns is not enforced for incoming connections. For TCP, investigate the server's connection handler to see where incoming connections are accepted and whether maxConns is checked before accepting. For WebRTC, look at the signaling process to understand when an offer is returned and if it can be suppressed when at capacity. Search for existing comments or related code in the repository, particularly files handling connection limits (e.g., 'lib/server.js' or similar). Evaluate whether pausing the TCP server or destroying connections immediately is feasible, and how to handle WebRTC connection capacity.