webtorrent/webtorrent-desktop

Consider using app.setLoginItemSettings(settings) API instead of auto-launch

Open

#1,135 创建于 2017年2月15日

在 GitHub 查看
 (2 评论) (6 反应) (0 负责人)JavaScript (9,423 star) (1,055 fork)batch import
acceptedenhancementgood first contributionhelp wanted

描述

Electron offers an official API for setting the app to start at login. Let's consider using it instead of auto-launch on Windows and Mac.

http://electron.atom.io/docs/api/app/#appsetloginitemsettingssettings-macos-windows

We may need to keep auto-launch around for Linux users.

贡献者指南

技术栈
javascriptelectronnodejs
领域
desktop
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Familiarity with Electron APIUnderstanding of auto launch library
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
Examine the current auto launch implementation in the repository (likely in main process files). Then review the Electron documentation for app.setLoginItemSettings. Implement the changes for Windows and macOS using the official API, and ensure the auto launch library is still used as a fallback for Linux. Test the login behavior on all three platforms. No linked PRs or comments providing additional direction.