webtorrent/webtorrent-desktop

Consider autoHideMenuBar browser window option for Linux

Open

#1,134 创建于 2017年2月14日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (9,423 star) (1,055 fork)batch import
acceptedenhancementgood first contributionhelp wanted

描述

Consider adding autoHideMenuBar to browser window on Linux, since the menu bar frequently looks terrible on non-Unity systems. It shouldn't have an effect on Ubuntu+Unity (the only Linux we officially support) since the menu bar isn't part of the window (it's like macOS).

This change needs to be tested.

贡献者指南

技术栈
javascriptelectron
领域
desktop
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Electron basicsLinux OS for testing
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Locate where BrowserWindow is instantiated, likely in a main process file such as 'main.js'. Add the 'autoHideMenuBar' option (set to true) only for non Unity Linux systems, as Unity handles the menu bar separately. Verify that the change does not break Ubuntu+Unity by testing on that environment as well. Test on a Linux distribution without Unity (e.g., Fedora with GNOME) to ensure the menu bar is hidden.