web-platform-tests/wpt

WebSocketDaemon attempted spawn even when ws_doc_root is null

Open

#8,675 创建于 2017年12月13日

在 GitHub 查看
 (7 评论) (0 反应) (0 负责人)HTML (4,581 star) (2,898 fork)batch import
good first issueinfrapriority:backlog

描述

If ws_doc_root is null (default in config.default.json), server.py still attempts to spawn WebSocketDaemons, which then fail due to lack of config.

I'm pretty new to wpt so not sure if desired behavior in this case is to

a) Require that ws_doc_root be set b) If ws_doc_root is not set, skip spawning WebSocketDaemon c) Make WebSocketDaemon handle null and default config better

For now, I assuming b) but defer to experts in terms of how this should be handled.

贡献者指南

技术栈
python
领域
backendtesting
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Python basicswpt configuration
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Review the discussion in the issue comments (7 comments) to see if maintainers have indicated a preference among options (a), (b), or (c). If no clear direction, implement option (b) as suggested by the author: skip spawning WebSocketDaemon when ws doc root is null. Modify the relevant code in server.py to check for null before spawning. Update config.default.json if necessary to set a default value or document the behavior.
WebSocketDaemon attempted spawn even when ws_doc_root is null · web-platform-tests/wpt#8675 | Good First Issue