wdullaer/MaterialDateTimePicker

Make TalkBack only read the value changed when something changes

Open

#617 创建于 2019年10月4日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Java (4,665 star) (961 fork)batch import
bughelp wanted

描述

Thanks for the great library!

We're experiencing an issue when using the timepicker with TalkBack enabled.

If you are on for example "Hour mode" (i.e. selecting hours), and you use 2 fingers to swipe to an hour, TalkBack only reads the seconds out loud. I.e "00". The same goes for minutes. If you are in AM/PM mode it only reads AM or PM.

I think this is related to the onValueSelected method in TimePickerDialog which sets the hours, minutes, seconds and amPmDisplay. These setters will in turn call Utils.tryAccessibilityAnnounce(mTimePicker, text);, which will try to read out the values. However, since the announcements all come at almost the same time, TalkBack will only announce the latest value. Which will either be the seconds or AM/PM.

Not sure what the best way is to fix this is. Maybe to diff the old value with the new value and only announce it if it's different?

贡献者指南

技术栈
javaandroid
领域
mobileaccessibility
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Android development environmentUnderstanding of Android accessibility APIs
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Investigate the `onValueSelected` method in `TimePickerDialog.java` to see how it updates hours, minutes, seconds, and AM/PM. Look at `Utils.tryAccessibilityAnnounce` to understand how announcements are made. The fix involves comparing old and new values before announcing, so only the changed value is announced.
Make TalkBack only read the value changed when something changes · wdullaer/MaterialDateTimePicker#617 | Good First Issue