vuetifyjs/vuetify

[Documentation] Font Awesome preset comments

Open

#12,522 创建于 2020年10月28日

在 GitHub 查看
 (0 评论) (0 反应) (1 负责人)TypeScript (40,995 star) (7,139 fork)batch import
Service: IconsT: documentationT: enhancementgood first issue

描述

Problem to solve

Clarity in icon usage for components, for delete and clear. Currently, it's confusing for people that use Font Awesome (5).

Proposed solution

Update comments in the fa.ts file, so it's more clear which components the icons are used in by default. Maybe include cancel and close too since those words all mean similar things.

image

贡献者指南

技术栈
typescriptvue
领域
documentation
议题类型
documentation
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
Examine the file packages/vuetify/src/services/icons/presets/fa.ts, particularly the comments for 'delete' and 'clear' icons. Identify which components (e.g., v btn) use these icons by default. Update the comments to clearly indicate the component and context, and consider adding annotations for 'cancel' and 'close' for clarity. No need to modify the icon mappings themselves.
[Documentation] Font Awesome preset comments · vuetifyjs/vuetify#12522 | Good First Issue