vuejs/vuepress

404 page does not support i18n

Open

#1,987 创建于 2019年10月27日

在 GitHub 查看
 (6 评论) (1 反应) (0 负责人)JavaScript (22,300 star) (4,782 fork)batch import
complexity: easycontribution welcomeeffort: mediumgood first issuetopic: themetype: feature request

描述

  • I confirm that this is an issue rather than a question.

Bug report

I just find this on stackoverflow, and test it on the official website

Steps to reproduce

Try to visit vuepress.vuejs.org/zh/test

What is expected?

A 404 page with Chinese and

<html lang="zh-CN" >

What is actually happening?

<html lang="en-US" >

Other relevant information

  • Output of npx vuepress info in my VuePress project:

贡献者指南

技术栈
vuejavascripthtml
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic VuePress projectUnderstanding of VuePress i18n
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
The 404 page is rendered by the NotFound.vue component in the default theme. The issue is that the HTML lang attribute is hardcoded to 'en US' instead of using the current locale. Look at packages/@vuepress/theme default/components/NotFound.vue and the i18n helper. The fix involves dynamically setting the lang attribute based on the site's locale and ensuring translated text is displayed. Check how other components like Navbar handle locale to follow the same pattern. No linked PRs or comments indicate a solution in progress.