vuejs/vue-router

The type definition of Route seems to be partially wrong

开放

#3,566 创建于 2021年6月9日

 (4 条评论) (0 个反应) (0 位负责人)JavaScript (5,092 个派生)batch import
Typescriptcontribution welcomefixed on 4.xgood first issue

仓库指标

星标
 (19,015 个星标)
PR 合并指标
 (30 天内没有已合并 PR)

描述

Version

3.5.1

Reproduction link

https://github.com/vuejs/vue-router/blob/dev/types/router.d.ts#L203

Steps to reproduce

None, just the source code seems to be wrong.

What is expected?

The type definition of Route#query should be

query: Dictionary<string | null | (string | null)[]>

The current implementation cannot express this type of query

/path?foo#bar

as it doesn't have any value and it is not converted to an array.

What is actually happening?

https://github.com/vuejs/vue-router/blob/dev/types/router.d.ts#L203

The type definition of Route#query is

query: Dictionary<string | (string | null)[]>

贡献者指南