volta-cli/volta

Investigate VS Code Git Tools & Pre-commit

Open

#516 创建于 2019年8月5日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Rust (8,309 star) (189 fork)batch import
help wantedquestion

描述

If your project has a pre-commit hook that calls a Node command, and you use VS Code Git Tools to initiate a commit, Volta appears to be finding the default Node instead of the Node specified in package.json.

A possible cause of this is VS Code is somehow executing the Git commit with a cwd that is outside of the project, causing Volta to start in the wrong directory and not find the project-local settings. If possible, we should correctly handle this case, or worst provide some guidance for how to set up VS Code to get the expected behavior.

贡献者指南

技术栈
rustnodejs
领域
toolingdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Familiarity with RustUnderstanding of VS Code Git Tools
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
25
研究方向
Investigate how Volta determines the current working directory when invoked by VS Code Git Tools, possibly in the launch or commit hook path. The issue suggests the cwd might be outside the project. Look at the Volta source code in the `src/` directory for functions that resolve Node versions, particularly around process environment and directory detection. Test with VS Code Git Tools to reproduce the bug. Consider adding a fallback or documentation for VS Code users.