vmware/pyvmomi-community-samples

Do not swallow errors!

Open

#11 创建于 2014年5月21日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Python (972 star) (914 fork)batch import
enhancementhelp wanted

描述

https://github.com/vmware/pyvmomi-community-samples/blob/master/samples/create_random_marvel_vms.py#L195

In sample code, don't trap errors coming off of ...

si = connect.SmartConnect(

... instead just expose those to the CLI. We are attempting to make teaching samples here and too thoroughly swallowing or handling errors can make the samples harder to read and understand for programmers who are still learning.

贡献者指南

技术栈
python
领域
documentation
议题类型
documentation
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic Python knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Start by examining the file `samples/create random marvel vms.py` around line 195 where `connect.SmartConnect` is called. Remove the error handling that swallows exceptions, allowing them to propagate to the CLI. Check if there are other samples with similar patterns.