videojs/video.js

Volume/Mute State Not Preserved Switching Between HTML5 and Flash Techs

Open

#2,066 创建于 2015年4月23日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (39,742 star) (7,502 fork)batch import
confirmedgood first issuepinnedunclaimed

描述

I see 2 problems with volume/mute handling in videojs:

  1. Html5 and Flash tech are inconsistent handling volume and muted. Html5 maintains 2 separate variables to hold the value for volume() and muted(). Flash on the other hand sets volume = 0 when muted(true) is called. My guess is Html5 is the proper implementation desired.
  2. The state stored for volume() and muted() are delegated to the Tech. Switching between Techs causes volume and muted states to be lost between the time unloadTech and loadTech is called. A simple hack is to add a couple lines inside loadTech to save the state of muted and volume and then reapply those states inside the techReady function. Going forward, I feel the Player core should hold these states.

I'm working off a modified version of v4.12.5

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Video.js basicsJavaScriptState management concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Examine the `loadTech` and `techReady` functions in the Video.js source code to understand current state handling. Look at how the HTML5 and Flash tech implementations handle `volume()` and `muted()` separately. Implement saving the volume and muted state in `loadTech` and reapplying in `techReady`, or alternatively refactor the Player core to hold these states. Consider the impact on existing tests and tech switching scenarios.