Fix exec call to remove cache folder · victorb/trymodule#15 | Good First Issue

(0 评论) (0 反应) (0 负责人)JavaScript (31 fork)github user discovery

enhancementhelp wanted

仓库指标

Star: (1,133 star)
PR 合并指标: (PR 指标待抓取)

描述

https://github.com/VictorBjelkholm/trymodule/blob/2030806d790213d426456959fdc7a69773a4c6f7/index.js#L59

Oh noes. Please don't. Never do string concat for commands, use execFile instead. Never pass environment variables directly to rm without sanitation, better yet, never spawn rm. Use a JS tools, like rimraf or even better del.

From: https://github.com/sindresorhus/awesome-nodejs/pull/477#event-606502245

贡献者指南

研究方向: 将 exec 调用替换为 execFile 或使用 rimraf 来安全地删除缓存文件夹。
技术栈: javascript
领域: cli
议题类型: 缺陷
难度: 2
预计时间: 1-3 小时
活动状态: 活跃
清晰度: 清晰
前置要求: Node.jsGit
新手友好度: 75