vercel/release

Can't release if there's only 1 commit since last tag

Open

#93 创建于 2017年6月30日

在 GitHub 查看
 (3 评论) (2 反应) (0 负责人)JavaScript (3,534 star) (145 fork)batch import
bughelp wanted

描述

I end up with the error Error! No changes happened since the last release. if I have only 1 commit since the last tag.

Seems like the following code might be the issue https://github.com/zeit/release/blob/master/lib/commits.js#L22

  if (commit.hash === release.hash) {
    return
  }

贡献者指南

技术栈
javascriptnodejs
领域
toolingrelease
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Node.jsbasic git knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
The issue is in lib/commits.js at line 22 where the code returns early if the commit hash matches the release hash. This causes a failure when there is only one commit since the last tag. To fix, the logic should be adjusted to handle the single commit case, possibly by not returning or by checking the number of commits. There are no linked PRs, so the solution is open for implementation. The maintainer has not commented on the issue, so the scope is defined by the reported bug.