vercel/next.js

ISG with GIP in _app overrides cache-control of ISG page

Open

#14,244 创建于 2020年6月16日

在 GitHub 查看
 (3 评论) (0 反应) (1 负责人)JavaScript (139,471 star) (31,066 fork)batch import
Pages Routergood first issuetype: next

描述

Bug report

When using the unstable_revalidate param with ISG, a header set by _app should never win.

Additional context

From @lfades:

Update: this is currently not the case, SSG finishes the request before it gets to _app.

the custom _app in the Next.js site was setting a header, but that causes an error because the request was sent, this happens in production and with next start, but in dev you don't get any error.

贡献者指南

技术栈
nextjsreactjavascripttypescript
领域
full stack
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Next.jsISGgetInitialPropscache control
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate how Next.js handles cache control headers when using ISG with getInitialProps in app. Look at the source files related to ISG, such as next server and router. A minimal reproduction would help confirm the issue. Check if there are existing tests for this scenario in the Next.js test suite.