Support Reporting Terminal Window in Pixels · vercel/hyper#962

2016-11-05T04:21:36.000Z

- **OS version and name**: Mac OSX 10.12 (16A323) - **Hyper.app version**: 0.8.3.873 ## Issue [threejs-tern](https://github.com/zz85/threejs-term) requires the actual pixel size of the terminal so it would be able to render a 3d scene with a more accurate aspect ratio. At the point of testing, Hyper does not seems to support pixel dimension reporting (although terminal size reporting and mouse works which is pretty cool!) Some code related to this issue is here. - https://github.com/zz85/threejs-term/blob/master/dom_polyfill.js#L106 - https://github.com/chjj/blessed/blob/master/lib/program.js#L3917 This issue isn't present using iTerm2 or Mac's Terminal.app. I'm not too familiar with the internals of Hyper, but my guess is that a fix for this issue would be to implement the CSI sequence P 1 4. ![image](https://cloud.githubusercontent.com/assets/314997/20027554/34377ce4-a352-11e6-9f68-11854ab6aebc.png) - from http://invisible-island.net/xterm/ctlseqs/ctlseqs.html

(5 评论) (0 反应) (0 负责人)TypeScript (44,582 star) (3,558 fork)batch import

help wanted🛠 Type: Feature Request🤯 Type: Compatibility

描述

OS version and name: Mac OSX 10.12 (16A323)
Hyper.app version: 0.8.3.873

Issue

threejs-tern requires the actual pixel size of the terminal so it would be able to render a 3d scene with a more accurate aspect ratio.

At the point of testing, Hyper does not seems to support pixel dimension reporting (although terminal size reporting and mouse works which is pretty cool!)

Some code related to this issue is here.

This issue isn't present using iTerm2 or Mac's Terminal.app.

I'm not too familiar with the internals of Hyper, but my guess is that a fix for this issue would be to implement the CSI sequence P 1 4.

from http://invisible-island.net/xterm/ctlseqs/ctlseqs.html

贡献者指南

技术栈: typescriptnodejs
领域: desktopcli
议题类型: feature
难度: 3
预计时间: 1-3 hours
活动状态: stale
清晰度: clear
前置要求: basic understanding of terminal protocolsfamiliarity with Hyper's source code
新手友好度: 40
研究方向: The issue requests implementing the CSI sequence 'P 1 4' for pixel dimension reporting. Relevant references include the 'dom polyfill.js' file in threejs term and 'program.js' in the blessed library. The fix likely involves handling the escape sequence in Hyper's terminal emulation code. Maintainers should provide guidance on where to add this support.