vercel/hyper

Request: add "tab:close" shortcut

Open

#3,548 创建于 2019年3月28日

在 GitHub 查看
 (8 评论) (0 反应) (0 负责人)TypeScript (44,582 star) (3,558 fork)batch import
help wanted🎨 Type: Enhancement

描述

Per https://github.com/zeit/hyper/blob/master/app/keymaps/win32.json, there is no shortcut to close tabs.

Adding "tab:close": "ctrl+w", to keymaps doesn't work.

Could you please add a "tab: close" shortcut?

Hyper 3 Canary 8, Windows 10.0.18860.0, can't see this reported in any other issue.

贡献者指南

技术栈
typescriptjavascriptelectron
领域
desktop
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with Hyper terminalBasic knowledge of Electron keyboard shortcutsUnderstanding of JSON keymaps
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Investigate how keyboard shortcuts are defined and registered in Hyper. Start by examining the keymaps file at `app/keymaps/win32.json` and similar files for other platforms. Look for the code that parses these keymaps and binds shortcuts, likely in the main process. The user reported that manually adding the entry did not work, so there may be a missing handler or conflict that needs to be resolved.