vectordotdev/vector

prometheus_exporter does not support Content-Encoding

Open

#19,962 创建于 2024年2月27日

在 GitHub 查看
 (8 评论) (1 反应) (0 负责人)Rust (21,837 star) (2,126 fork)batch import
good first issuesink: prometheus_exportertype: feature

描述

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

Vector's prometheus_exporter does not appear to support gzip content-encoding:

$ curl -v --compressed http://localhost:9598/metrics
*   Trying [::1]:9598...
* Connected to localhost (::1) port 9598
> GET /metrics HTTP/1.1
> Host: localhost:9598
> User-Agent: curl/8.4.0
> Accept: */*
> Accept-Encoding: deflate, gzip, br, zstd
>
< HTTP/1.1 200 OK
< content-type: text/plain; version=0.0.4
< content-length: 103854
< date: Tue, 27 Feb 2024 20:42:05 GMT
<
# HELP vector_adaptive_concurrency_averaged_rtt adaptive_concurrency_averaged_rtt
...

Whereas other Promtheus exporters such as node_exporter automagically do this:

$ curl -I --compressed -v http://localhost:9100/metrics
*   Trying [::1]:9100...
* Connected to localhost (::1) port 9100
> HEAD /metrics HTTP/1.1
> Host: localhost:9100
> User-Agent: curl/8.4.0
> Accept: */*
> Accept-Encoding: deflate, gzip, br, zstd
>
< HTTP/1.1 200 OK
HTTP/1.1 200 OK
< Content-Encoding: gzip
Content-Encoding: gzip
< Content-Type: text/plain; version=0.0.4; charset=utf-8
Content-Type: text/plain; version=0.0.4; charset=utf-8
< Date: Tue, 27 Feb 2024 20:43:28 GMT
Date: Tue, 27 Feb 2024 20:43:28 GMT

I have many metrics on the same key / labels - so would be beneficial to have this compressed at the network-layer.

Attempted Solutions

No response

Proposal

No response

References

No response

Version

0.34.1

贡献者指南

技术栈
rust
领域
backendperformance
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
RustHTTP compressionVector codebase familiarity
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Start by examining the prometheus exporter source code in Vector, likely under src/sources/prometheus/ or src/sinks/prometheus/. Look for the HTTP response handler that serves /metrics. The issue requires adding support for gzip compression based on the Accept Encoding request header. Check if Vector already uses a compression library like flate2 or async compression. Implement middleware or modify the response to set Content Encoding header and compress the body when the client supports gzip. Refer to existing patterns like the node exporter's approach or other HTTP endpoints in Vector that already support compression.