valyala/fasthttp

How to integrate fasthttp client with opentracing gracefully

Open

#775 创建于 2020年4月7日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Go (21,741 star) (1,755 fork)batch import
help wanted

描述

net/http expose RoundTrip so it can integrate with opentracing by overwrite the RoundTrip function. while fasthttp client don't implement such interface and do not provide middleware. The only way to integrate with opentracing is overwrite all method of fasthttp client, but it is not graceful.

贡献者指南

技术栈
go
领域
backendobservability
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go programmingKnowledge of OpenTracing conceptsFamiliarity with fasthttp client
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
The issue requests a graceful way to integrate OpenTracing with the fasthttp client, similar to net/http's RoundTrip mechanism. Research the net/http opentracing integration in opentracing contrib/go stdlib (nethttp/client.go) to understand the approach. Examine fasthttp's client source code (client.go) to identify where a middleware or interceptor could be added without compromising performance. Consider designing a client wrapper or method level hooks. Discuss the proposed design with maintainers in the issue comments.
How to integrate fasthttp client with opentracing gracefully · valyala/fasthttp#775 | Good First Issue