valyala/fasthttp

Recommendation on cleaning of HostClient.

已关闭

#726 创建于 2020年1月12日

 (2 条评论) (0 个反应) (0 位负责人)Go (1,755 个派生)batch import
help wantedquestion

仓库指标

星标
 (21,741 个星标)
PR 合并指标
 (平均合并 3天) (30 天内合并 44 个 PR)

描述

As of now the only way to override Host header is to use HostClient as per Issue 318. This means we have to manage reusing/cleanup of HostClients ourselves which fasthttp.Client provided out of the box.

We will be writing something very similar to fasthttp.Client to handle this. Is it ok to remove the HostClient if it is not being used from more than MaxIdleConnDuration*2 or something, as we are sure all goroutines for individual connection cleaning would have run? We don't have access to connsCount as it is an unexported field and was modified to use connsCount instead of time.

if t.Sub(v.LastUseTime()) > (MaxIdleConnDuration*2) {
				delete(m, k)
			}

If not, what is the recommendation here?

贡献者指南