valyala/fasthttp

Request should not fail on small ReadBufferSize

Open

#1,873 创建于 2024年9月24日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)Go (21,741 star) (1,755 fork)batch import
help wantedwontfix

描述

Can we not fail request if the req/resp header size is greater than the read buffer size.

I can see a bufio bug was mentioned for tryRead function but looks like it's resolved now. Can we have the above mentioned behaviour?

Also, some callback could also be configured to inform that buffer size was low. Library users could emit metrics and increase the buffer size appropriately to have best balance between memory usage and CPU usage.

@valyala Could you review the request?

贡献者指南

技术栈
gorest api
领域
backendperformance
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Understanding of GoFamiliarity with fasthttp's bufferingReading header.go file
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
First, read the fasthttp header.go file, especially the tryRead function at line 2128 and the surrounding buffer logic. Understand how ReadBufferSize affects request parsing. The issue references a Go bug (golang/go#14121) which is already resolved; investigate if that resolution can be applied to fasthttp. Additionally, consider implementing a callback mechanism to inform users when buffer size is low, allowing them to adjust. Check the existing comments for any maintainer feedback or additional context.