valyala/fasthttp

It is not safe to read all stream body to memory without a max size limit.

Open

#1,765 创建于 2024年4月23日

在 GitHub 查看
 (8 评论) (0 反应) (0 负责人)Go (21,741 star) (1,755 fork)batch import
help wanted

描述

https://github.com/valyala/fasthttp/blob/57b9352ad1cc93a0aaaa72b2130e03ace8a5b118/http.go#L427 I think it would be safe to stop reading the request body into memory and return an error when it exceeds the maximum request body size. Otherwise, it may lead to an out-of-memory (OOM) error when the request body is too large.

贡献者指南

技术栈
go
领域
backendsecurity
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Go basicsHTTP server internals
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
The issue points to line 427 in http.go where the entire request body is read into memory without a size limit. To fix, add a check for a maximum request body size before reading, preferably using a configurable limit (e.g., MaxRequestBodySize). When exceeded, the read should stop and return an error, likely with a 413 status code. Ensure integration with the existing fasthttp request handling pipeline and consider any existing size settings.
It is not safe to read all stream body to memory without a max size limit. · valyala/fasthttp#1765 | Good First Issue